Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation on centOS with gcc 11.2.0 #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compilation on centOS with gcc 11.2.0 #27

wants to merge 1 commit into from

Conversation

jeizenga
Copy link

@jeizenga jeizenga commented Feb 7, 2023 •
edited
Loading

I had to make some tweaks to get this to compile/run on my compute server:

  • Used rm -f instead of -rm so that make doesn't report itself as having failed if the config doesn't already exist
  • Added a missing include of <optional>
  • Removed the variadic constructors for Schismatic. For some reason, these are parsed as a syntax error by gcc 11.2.0. I don't fully understand what the problem is, but it seems like they weren't used anywhere in this codebase anyway.

Resolves #22

@RunpengLuo
Copy link

This commit solved my compilation problem on Ubuntu and gcc 12.2.0, appreciate that!

@deilepaita
Copy link

This solved my compilation problem too! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install issue - optional and variadic templates
3 participants
@jeizenga @RunpengLuo @deilepaita